[GitHub] [flink] matriv commented on pull request #17900: [FLINK-24803][Table SQL/Planner] Fix cast BINARY/VARBINARY to STRING

2021-12-30 Thread GitBox
matriv commented on pull request #17900: URL: https://github.com/apache/flink/pull/17900#issuecomment-1002938331 @shenzhu , thx for your initial effort! We just wanted to finish up the BINARY related casting, and felt quicker to do the rebasing and apply the adjustments for padding & trimm

[GitHub] [flink] matriv commented on pull request #17900: [FLINK-24803][Table SQL/Planner] Fix cast BINARY/VARBINARY to STRING

2021-12-28 Thread GitBox
matriv commented on pull request #17900: URL: https://github.com/apache/flink/pull/17900#issuecomment-1002056389 @shenzhu I've taken over the PR and made the necessary adjustments to also incorporate padding and trimming. This is is superseded by: https://github.com/apache/flink/pull/182

[GitHub] [flink] matriv commented on pull request #17900: [FLINK-24803][Table SQL/Planner] Fix cast BINARY/VARBINARY to STRING

2021-12-22 Thread GitBox
matriv commented on pull request #17900: URL: https://github.com/apache/flink/pull/17900#issuecomment-999440449 @shenzhu Do you have time to finish up this soon, otherwise we would like to take over and finish up the BINARY related Cast issues. -- This is an automated message from the Ap

[GitHub] [flink] matriv commented on pull request #17900: [FLINK-24803][Table SQL/Planner] Fix cast BINARY/VARBINARY to STRING

2021-12-17 Thread GitBox
matriv commented on pull request #17900: URL: https://github.com/apache/flink/pull/17900#issuecomment-996745167 @shenzhu Could you please rebase with master and fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [flink] matriv commented on pull request #17900: [FLINK-24803][Table SQL/Planner] Fix cast BINARY/VARBINARY to STRING

2021-12-14 Thread GitBox
matriv commented on pull request #17900: URL: https://github.com/apache/flink/pull/17900#issuecomment-993703133 I'm also +1 to not guard this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] matriv commented on pull request #17900: [FLINK-24803][Table SQL/Planner] Fix cast BINARY/VARBINARY to STRING

2021-12-13 Thread GitBox
matriv commented on pull request #17900: URL: https://github.com/apache/flink/pull/17900#issuecomment-992700911 @slinkydeveloper @twalthr Should we "guard" this change with the use of the legacyBehaviour flag? -- This is an automated message from the Apache Git Service. To respond to the