metaswirl commented on pull request #18169:
URL: https://github.com/apache/flink/pull/18169#issuecomment-1017535511
> You could take a look at `AbstractTaskManagerProcessFailureRecoveryTest`.
I think what could work is to start a `StandaloneSessionClusterEntrypoint` that
starts a `RM`. The
metaswirl commented on pull request #18169:
URL: https://github.com/apache/flink/pull/18169#issuecomment-1018510409
This change no longer adds the shutdown hook, as this has already been done
by commit: dd6069fabf8a7ff65fbd9ff8dd7b0c47f492288f.
--
This is an automated message from the Ap
metaswirl commented on pull request #18169:
URL: https://github.com/apache/flink/pull/18169#issuecomment-1018807185
> Sorry for the inconveniences I've caused with my merge. It caused just
more trouble. 🙏
Thank you for fixing the code 👍
--
This is an automated message from the Ap
metaswirl commented on pull request #18169:
URL: https://github.com/apache/flink/pull/18169#issuecomment-1011470263
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
metaswirl commented on pull request #18169:
URL: https://github.com/apache/flink/pull/18169#issuecomment-1013875342
> Also I would probably choose the Phaser approach as I find the interface
kind of confusing, by no objections there.
Do you have an alternative approach in mind? (lock
metaswirl commented on pull request #18169:
URL: https://github.com/apache/flink/pull/18169#issuecomment-1013909245
> Thanks for explaining how the Yarn logic works @metaswirl. I think this is
a good solution and works. One last question is whether we want to add an IT
test that ensures th
metaswirl commented on pull request #18169:
URL: https://github.com/apache/flink/pull/18169#issuecomment-1014267066
> Thanks for updating this PR @metaswirl. Concerning the test I was more
thinking about a test where we kill a TM process via `SIGTERM` and check that
it shuts down (e.g. der
