[GitHub] [flink] paul8263 commented on pull request #16352: [FLINK-23102][runtime] Accessing FlameGraphs while not being enabled …

2021-07-22 Thread GitBox
paul8263 commented on pull request #16352: URL: https://github.com/apache/flink/pull/16352#issuecomment-885392313 Hi @zentol , I did the rebase and now it should be OK. Thank you for your advice. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [flink] paul8263 commented on pull request #16352: [FLINK-23102][runtime] Accessing FlameGraphs while not being enabled …

2021-07-20 Thread GitBox
paul8263 commented on pull request #16352: URL: https://github.com/apache/flink/pull/16352#issuecomment-882969525 Hi @NicoK , I successfully regenerated rest_v1_dispatcher.html and rest_api_v1.snapshot by running those commands. But I am still confused about the first point "Rebase onto la

[GitHub] [flink] paul8263 commented on pull request #16352: [FLINK-23102][runtime] Accessing FlameGraphs while not being enabled …

2021-07-20 Thread GitBox
paul8263 commented on pull request #16352: URL: https://github.com/apache/flink/pull/16352#issuecomment-882969525 Hi @NicoK , I successfully regenerated rest_v1_dispatcher.html and rest_api_v1.snapshot by running those commands. But I am still confused about the first point "Rebase onto la

[GitHub] [flink] paul8263 commented on pull request #16352: [FLINK-23102][runtime] Accessing FlameGraphs while not being enabled …

2021-07-19 Thread GitBox
paul8263 commented on pull request #16352: URL: https://github.com/apache/flink/pull/16352#issuecomment-882969525 Hi @NicoK , I successfully regenerated rest_v1_dispatcher.html and rest_api_v1.snapshot by running those commands. But I am still confused about the first point "Rebase onto la

[GitHub] [flink] paul8263 commented on pull request #16352: [FLINK-23102][runtime] Accessing FlameGraphs while not being enabled …

2021-07-09 Thread GitBox
paul8263 commented on pull request #16352: URL: https://github.com/apache/flink/pull/16352#issuecomment-877044317 Hi @zentol @NicoK ,I separated the erroneous state(disabled, waiting for the first samples, etc.) of flame graph by assigning different negative value for flameGraph.endTimesta

[GitHub] [flink] paul8263 commented on pull request #16352: [FLINK-23102][runtime] Accessing FlameGraphs while not being enabled …

2021-07-08 Thread GitBox
paul8263 commented on pull request #16352: URL: https://github.com/apache/flink/pull/16352#issuecomment-876936422 In the commit fd2bdde, if user accessed the flame graph tab with flame graph setting disabled, it would result in an exception which tells the user that flame graph is disabled

[GitHub] [flink] paul8263 commented on pull request #16352: [FLINK-23102][runtime] Accessing FlameGraphs while not being enabled …

2021-07-08 Thread GitBox
paul8263 commented on pull request #16352: URL: https://github.com/apache/flink/pull/16352#issuecomment-876353435 @zentol I executed the command mvn verify -Dtest=RestApiStabilityTest -Dgenerate-rest-snapshot -pl flink-runtime but got a no tests to run error. Is there anything wrong with t