[GitHub] [flink] pnowojski edited a comment on pull request #11541: [FLINK-15416][network] add task manager netty client retry mechenism

pnowojski edited a comment on pull request #11541: URL: https://github.com/apache/flink/pull/11541#issuecomment-644162219 Can you explain what was the deadlock scenario? I haven't got time to fully analyse your solution, but `ConcurrentMap<...> clients` is being used in other

[GitHub] [flink] pnowojski edited a comment on pull request #11541: [FLINK-15416][network] add task manager netty client retry mechenism

pnowojski edited a comment on pull request #11541: URL: https://github.com/apache/flink/pull/11541#issuecomment-643201173 > how about putting ignore only in the method testResourceReleaseAfterInterruptedConnect? I haven't thought about that :) Yep, it's an obvious simple solution.

[GitHub] [flink] pnowojski edited a comment on pull request #11541: [FLINK-15416][network] add task manager netty client retry mechenism

pnowojski edited a comment on pull request #11541: URL: https://github.com/apache/flink/pull/11541#issuecomment-642709638 Thanks for the udpate @HuangZhenQiu > There is no test that is marked to ignore by this PR. Would you please double-check? The whole

[GitHub] [flink] pnowojski edited a comment on pull request #11541: [FLINK-15416][network] add task manager netty client retry mechenism

pnowojski edited a comment on pull request #11541: URL: https://github.com/apache/flink/pull/11541#issuecomment-638644705 There are a couple of things left to do there. 1. For example test is marked with Ignore and I’m not sure if that’s a mistake, as the commit marking it ignored