[GitHub] [flink] reswqa commented on a diff in pull request #21419: [FLINK-30233] Hybrid full result partition should also work with speculative execution

2022-12-06 Thread GitBox
reswqa commented on code in PR #21419: URL: https://github.com/apache/flink/pull/21419#discussion_r1040779118 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataManager.java: ## @@ -181,18 +188,33 @@ public HsDataView registerNewConsu

[GitHub] [flink] reswqa commented on a diff in pull request #21419: [FLINK-30233] Hybrid full result partition should also work with speculative execution

2022-12-06 Thread GitBox
reswqa commented on code in PR #21419: URL: https://github.com/apache/flink/pull/21419#discussion_r1040712945 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/SpeculativeExecutionVertex.java: ## @@ -295,6 +296,14 @@ void cachePartitionInfo(PartitionInfo par

[GitHub] [flink] reswqa commented on a diff in pull request #21419: [FLINK-30233] Hybrid full result partition should also work with speculative execution

2022-12-05 Thread GitBox
reswqa commented on code in PR #21419: URL: https://github.com/apache/flink/pull/21419#discussion_r1040387708 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IntermediateResultPartition.java: ## @@ -46,7 +46,7 @@ public class IntermediateResultPartition {

[GitHub] [flink] reswqa commented on a diff in pull request #21419: [FLINK-30233] Hybrid full result partition should also work with speculative execution

2022-12-05 Thread GitBox
reswqa commented on code in PR #21419: URL: https://github.com/apache/flink/pull/21419#discussion_r1040387708 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IntermediateResultPartition.java: ## @@ -46,7 +46,7 @@ public class IntermediateResultPartition {