[GitHub] [flink] reswqa commented on a diff in pull request #22196: [FLINK-31445][runtime]Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

2023-03-21 Thread via GitHub
reswqa commented on code in PR #22196: URL: https://github.com/apache/flink/pull/22196#discussion_r1143047050 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedTaskManagerTracker.java: ## @@ -387,14 +520,187 @@ public ResourceProfile

[GitHub] [flink] reswqa commented on a diff in pull request #22196: [FLINK-31445][runtime]Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

2023-03-20 Thread via GitHub
reswqa commented on code in PR #22196: URL: https://github.com/apache/flink/pull/22196#discussion_r1142918984 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerRuntimeServices.java: ## @@ -83,7 +83,13 @@ private static SlotManager

[GitHub] [flink] reswqa commented on a diff in pull request #22196: [FLINK-31445][runtime]Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

2023-03-20 Thread via GitHub
reswqa commented on code in PR #22196: URL: https://github.com/apache/flink/pull/22196#discussion_r1141829794 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedTaskManagerTrackerTest.java: ## @@ -18,144 +18,191 @@ package