reswqa commented on PR #21673:
URL: https://github.com/apache/flink/pull/21673#issuecomment-1463394127
@XComp Very sorry for this. This PR has two commits, the first is a `hotfix`
that only migrates test to junit5. I take it for granted that it will not have
code format problems, so it is
reswqa commented on PR #21673:
URL: https://github.com/apache/flink/pull/21673#issuecomment-1462548896
FYI, I have revert this via 593cc139ab30bb81ab38d94b7b697d00eaaecada.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
reswqa commented on PR #21673:
URL: https://github.com/apache/flink/pull/21673#issuecomment-1462125772
cc @X-czh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reswqa commented on PR #21673:
URL: https://github.com/apache/flink/pull/21673#issuecomment-1461857033
Thanks @XComp and @dmvk for pointing this! Sorry for didn't take this into
account when reviewing the code. Do we need to revert this change first (only
merged into master branch at
reswqa commented on PR #21673:
URL: https://github.com/apache/flink/pull/21673#issuecomment-1461341895
@X-czh merged. Could you open a backport pr to release-1.17?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
reswqa commented on PR #21673:
URL: https://github.com/apache/flink/pull/21673#issuecomment-1458153115
In general, We should put the commit of junit5 migration first and regard it
as hotfix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
