[GitHub] [flink] rionmonster commented on pull request #15175: [FLINK-16829] Refactored Prometheus Metric Reporters to use construct…

2021-03-15 Thread GitBox
rionmonster commented on pull request #15175: URL: https://github.com/apache/flink/pull/15175#issuecomment-799464292 @zentol I've made the changes you mentioned and ran through the checkstyle a few times to make sure that we caught any of the discrepancies that it picked up

[GitHub] [flink] rionmonster commented on pull request #15175: [FLINK-16829] Refactored Prometheus Metric Reporters to use construct…

2021-03-12 Thread GitBox
rionmonster commented on pull request #15175: URL: https://github.com/apache/flink/pull/15175#issuecomment-797867198 @zentol I decided to make another, different pass at this guy since the last PR seemed to be a bit all over the place. I migrated almost all of the logic to