[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-19 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r427084714 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/FileBasedBufferIterator.java ## @@ -85,6 +90,6 @@ private int

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-18 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r426612454 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/FileBasedBufferIterator.java ## @@ -85,6 +90,6 @@ private int

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-17 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r426263155 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/FileBasedBufferIterator.java ## @@ -85,6 +90,6 @@ private int

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-16 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r426139079 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/FileBasedBufferIterator.java ## @@ -85,6 +90,6 @@ private int

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-15 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r425605033 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/NonSpanningWrapper.java ## @@ -290,4 +309,49 @@

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-15 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r425600935 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java ## @@ -67,8 +70,11

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r425096713 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java ##

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r425073734 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java ## @@ -82,187 +94,171 @@

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r425069312 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java ##

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r425068399 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java ##

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r425065870 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/NonSpanningWrapper.java ## @@ -290,4 +313,55 @@

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r424950590 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/NonSpanningWrapper.java ## @@ -47,27 +64,33 @@ void

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r424949957 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java ##

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r424948283 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java ## @@ -43,15 +46,18 @@

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r424941876 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java ## @@ -82,187 +94,171 @@

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r424938864 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java ## @@ -183,22 +196,26 @@

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r424919609 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequest.java ## @@ -46,8 +48,27 @@ static

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-14 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r424919609 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequest.java ## @@ -46,8 +48,27 @@ static