[GitHub] [flink] rkhachatryan commented on a diff in pull request #22584: [FLINK-31963][state] Fix rescaling bug in recovery from unaligned checkpoints.

2023-05-16 Thread via GitHub
rkhachatryan commented on code in PR #22584: URL: https://github.com/apache/flink/pull/22584#discussion_r1194923077 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointRescaleITCase.java: ## @@ -459,46 +478,61 @@ public void

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22584: [FLINK-31963][state] Fix rescaling bug in recovery from unaligned checkpoints.

2023-05-16 Thread via GitHub
rkhachatryan commented on code in PR #22584: URL: https://github.com/apache/flink/pull/22584#discussion_r1194862690 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -136,19 +136,24 @@ public void assignStates() {

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22584: [FLINK-31963][state] Fix rescaling bug in recovery from unaligned checkpoints.

2023-05-15 Thread via GitHub
rkhachatryan commented on code in PR #22584: URL: https://github.com/apache/flink/pull/22584#discussion_r1193902234 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -136,19 +136,24 @@ public void assignStates() {

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22584: [FLINK-31963][state] Fix rescaling bug in recovery from unaligned checkpoints.

2023-05-15 Thread via GitHub
rkhachatryan commented on code in PR #22584: URL: https://github.com/apache/flink/pull/22584#discussion_r1193908276 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperationTest.java: ## @@ -1029,6 +1192,15 @@ private JobVertex createJobVertex(