rkhachatryan opened a new pull request #12478:
URL: https://github.com/apache/flink/pull/12478
__This is a draft PR. It depends on #12457 and should not be merged before__
## What is the purpose of the change
Before FLINK-17218 there were two problems:
1. Exceeding `ChannelStateWriterImpl.maxCheckpoints`
1. Race condition with out of order barriers (see
be8fbcf506b8dd38e5425cf772a55f033f0962b0 of this PR)
FLINK-17218 (24ff415f1b76392f75dea7c3538558d24fcb7058) fixed the first one
but introduced a new race condition when netty thread modifies a
ChannelStateWriter map used by the task thread.
This PR reverts FLINK-17218 and addresses the issues above.
## Brief change log
1. Revert 24ff415f1b76392f75dea7c3538558d24fcb7058
`"[FLINK-17218][checkpointing] Ensuring that ChannelStateWriter aborts previous
checkpoints before a new checkpoint`
1. Abort channel state write if checkpoint is subsumed - using future
callback and task thread - fix race condition
1. Increase `ChannelStateWriterImpl.DEFAULT_MAX_CHECKPOINTS` - fix the
original problem of `FLINK-17218`
1. Ignore out of order checkpoints in `SubtaskCheckpointCoordinator` - fix a
more subtle race condition
1. Unignore `UnalignedCheckpointITCase`
## Verifying this change
Unignore `UnalignedCheckpointITCase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
