[GitHub] [flink] rmetzger commented on pull request #14910: [FLINK-21259] Add Failing state for DeclarativeScheduler

2021-02-15 Thread GitBox
rmetzger commented on pull request #14910: URL: https://github.com/apache/flink/pull/14910#issuecomment-779609292 Thanks for the review! I'll merge this now. This is an automated message from the Apache Git Service. To

[GitHub] [flink] rmetzger commented on pull request #14910: [FLINK-21259] Add Failing state for DeclarativeScheduler

2021-02-15 Thread GitBox
rmetzger commented on pull request #14910: URL: https://github.com/apache/flink/pull/14910#issuecomment-779248893 Thanks for your review. I addressed your comments! This is an automated message from the Apache Git Service.

[GitHub] [flink] rmetzger commented on pull request #14910: [FLINK-21259] Add Failing state for DeclarativeScheduler

2021-02-11 Thread GitBox
rmetzger commented on pull request #14910: URL: https://github.com/apache/flink/pull/14910#issuecomment-777562133 I addressed all your comments (note: "the address feedback" commit contains 98% of my changes. I messed up an interactive rebase, the "add tests" commit contains a move of

[GitHub] [flink] rmetzger commented on pull request #14910: [FLINK-21259] Add Failing state for DeclarativeScheduler

2021-02-10 Thread GitBox
rmetzger commented on pull request #14910: URL: https://github.com/apache/flink/pull/14910#issuecomment-776936981 Rebased to latest master, will address the comments tomorrow (ideally after the Canceling PR is merged, so that I can share the MockExecutionGraph).