[GitHub] [flink] shenzhu commented on pull request #17793: [FLINK-21565][Table SQL/API] Support more integer types in TIMESTAMPADD

2022-02-25 Thread GitBox
shenzhu commented on pull request #17793: URL: https://github.com/apache/flink/pull/17793#issuecomment-1051367428 > apache/flink@3ebe919 Hey @beyond1920 , thanks for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] shenzhu commented on pull request #17793: [FLINK-21565][Table SQL/API] Support more integer types in TIMESTAMPADD

2022-02-20 Thread GitBox
shenzhu commented on pull request #17793: URL: https://github.com/apache/flink/pull/17793#issuecomment-1046524892 Hey @wuchong @beyond1920 , would you mind taking a look at this PR when you have a moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] shenzhu commented on pull request #17793: [FLINK-21565][Table SQL/API] Support more integer types in TIMESTAMPADD

2021-12-15 Thread GitBox
shenzhu commented on pull request #17793: URL: https://github.com/apache/flink/pull/17793#issuecomment-995513366 Hey @zentol , would you mind taking a look at this PR when you have a moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] shenzhu commented on pull request #17793: [FLINK-21565][Table SQL/API] Support more integer types in TIMESTAMPADD

2021-12-11 Thread GitBox
shenzhu commented on pull request #17793: URL: https://github.com/apache/flink/pull/17793#issuecomment-991843941 Hey @twalthr @wuchong , could you please take a look at this PR when you have a moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] shenzhu commented on pull request #17793: [FLINK-21565][Table SQL/API] Support more integer types in TIMESTAMPADD

2021-12-02 Thread GitBox
shenzhu commented on pull request #17793: URL: https://github.com/apache/flink/pull/17793#issuecomment-985199167 Hey @twalthr , sorry to bother you, would you mind taking a look at this PR when you have a moment? Thanks! -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] shenzhu commented on pull request #17793: [FLINK-21565][Table SQL/API] Support more integer types in TIMESTAMPADD

2021-12-01 Thread GitBox
shenzhu commented on pull request #17793: URL: https://github.com/apache/flink/pull/17793#issuecomment-984282352 Hey @wuchong , would you mind taking a look at this PR when you have a moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] shenzhu commented on pull request #17793: [FLINK-21565][Table SQL/API] Support more integer types in TIMESTAMPADD

2021-11-25 Thread GitBox
shenzhu commented on pull request #17793: URL: https://github.com/apache/flink/pull/17793#issuecomment-978933817 Hey @twalthr , would you mind taking a look at this PR when you have a moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] shenzhu commented on pull request #17793: [FLINK-21565][Table SQL/API] Support more integer types in TIMESTAMPADD

2021-11-15 Thread GitBox
shenzhu commented on pull request #17793: URL: https://github.com/apache/flink/pull/17793#issuecomment-969476989 > Good job. @shenzhu . it looks to me on the whole. It would be better if you could add some ITest cases for the change . Hey @RocMarshal , thanks for your review! I