[GitHub] [flink] shuiqiangchen commented on a diff in pull request #20745: [FLINK-28988] Don't push filters down into the right table for temporal join

2022-11-22 Thread GitBox
shuiqiangchen commented on code in PR #20745: URL: https://github.com/apache/flink/pull/20745#discussion_r1030072896 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java: ## @@ -128,7 +129,9 @@ protected

[GitHub] [flink] shuiqiangchen commented on a diff in pull request #20745: [FLINK-28988] Don't push filters down into the right table for temporal join

2022-11-22 Thread GitBox
shuiqiangchen commented on code in PR #20745: URL: https://github.com/apache/flink/pull/20745#discussion_r1030072896 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java: ## @@ -128,7 +129,9 @@ protected