[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-16 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r807755945 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/CastRuleProvider.java ## @@ -107,6 +

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-15 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r807008892 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/CastRuleProvider.java ## @@ -107,6 +

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-15 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r807059562 ## File path: docs/data/sql_functions.yml ## @@ -561,7 +561,10 @@ conditional: conversion: - sql: CAST(value AS type) table: ANY.cast(TYP

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-15 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r807057297 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/converter/converters/TryCastConverter.java ###

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-15 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r807055482 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/SqlTryCastFunction.java ## @@ -0,0 +1,11

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-15 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r807052617 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java ## @@ -1529,6 +1529,20 @@ public

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-15 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r807013629 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RowToRowCastRule.java ## @@ -224,4 +

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-15 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r807014162 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/FlinkAssertions.java ## @@ -117,7 +117

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-15 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r807008892 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/CastRuleProvider.java ## @@ -107,6 +

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-04 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r799599345 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCastRule.java ## @@ -33,7 +3

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-04 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r799550754 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCastRule.java ## @@ -33,7 +3

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-04 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r799498720 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCastRule.java ## @@ -33,7 +3

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-04 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r799497976 ## File path: docs/data/sql_functions.yml ## @@ -561,7 +561,7 @@ conditional: conversion: - sql: CAST(value AS type) table: ANY.cast(TYPE

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-04 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r799449032 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/BaseExpressions.java ## @@ -476,6 +477,15 @@ pub

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-04 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r799445357 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCastRule.java ## @@ -33,7 +3

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-04 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r799443813 ## File path: docs/data/sql_functions.yml ## @@ -561,7 +561,10 @@ conditional: conversion: - sql: CAST(value AS type) table: ANY.cast(TYP

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-04 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r799369211 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRuleProviderTest.java ## @@ -77,

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18611: [FLINK-24385][table] Introduce TRY_CAST

2022-02-04 Thread GitBox
slinkydeveloper commented on a change in pull request #18611: URL: https://github.com/apache/flink/pull/18611#discussion_r799350285 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/FlinkAssertions.java ## @@ -117,7 +117