[GitHub] [flink] slinkydeveloper commented on pull request #19025: [FLINK-26553][build] Configure scalafmt

2022-04-12 Thread GitBox
slinkydeveloper commented on PR #19025: URL: https://github.com/apache/flink/pull/19025#issuecomment-1096591741 @twalthr I checked a bit and I couldn't find for both of the two problems you raised a solution in the configuraiton https://scalameta.org/scalafmt/docs/configuration.html. About

[GitHub] [flink] slinkydeveloper commented on pull request #19025: [FLINK-26553][build] Configure scalafmt

2022-03-29 Thread GitBox
slinkydeveloper commented on pull request #19025: URL: https://github.com/apache/flink/pull/19025#issuecomment-1081643377 @zentol do we wanna merge this now that 1.15 branch has been cut? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] slinkydeveloper commented on pull request #19025: [FLINK-26553][build] Configure scalafmt

2022-03-09 Thread GitBox
slinkydeveloper commented on pull request #19025: URL: https://github.com/apache/flink/pull/19025#issuecomment-1063131040 There is one pitfall to this PR. If you do `mvn checkstyle:apply` in a subdirectory project (e.g. `cd flink-scala && mvn spotless:apply`), it will fail cause it can't f