[GitHub] [flink] snuyanzin commented on a diff in pull request #18109: [FLINK-25284][Table SQL / API] Add proportion of null values to generate with datagen

2022-04-12 Thread GitBox
snuyanzin commented on code in PR #18109: URL: https://github.com/apache/flink/pull/18109#discussion_r848504911 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenConnectorOptions.java: ## @@ -109,5 +110,12 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #18109: [FLINK-25284][Table SQL / API] Add proportion of null values to generate with datagen

2022-04-12 Thread GitBox
snuyanzin commented on code in PR #18109: URL: https://github.com/apache/flink/pull/18109#discussion_r848504683 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -178,6 +192,10 @@ public void testS