[GitHub] [flink] snuyanzin commented on a diff in pull request #19873: [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

2023-05-22 Thread via GitHub
snuyanzin commented on code in PR #19873: URL: https://github.com/apache/flink/pull/19873#discussion_r1200843371 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayAppendPrependTypeStrategy.java: ## @@ -0,0 +1,55 @@ +/* + *

[GitHub] [flink] snuyanzin commented on a diff in pull request #19873: [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

2023-03-30 Thread via GitHub
snuyanzin commented on code in PR #19873: URL: https://github.com/apache/flink/pull/19873#discussion_r1153853228 ## docs/data/sql_functions.yml: ## @@ -617,6 +617,12 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns

[GitHub] [flink] snuyanzin commented on a diff in pull request #19873: [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

2023-03-30 Thread via GitHub
snuyanzin commented on code in PR #19873: URL: https://github.com/apache/flink/pull/19873#discussion_r1153851661 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -178,6 +179,35 @@ ANY,

[GitHub] [flink] snuyanzin commented on a diff in pull request #19873: [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

2023-03-29 Thread via GitHub
snuyanzin commented on code in PR #19873: URL: https://github.com/apache/flink/pull/19873#discussion_r1152441866 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -178,6 +179,35 @@ ANY,

[GitHub] [flink] snuyanzin commented on a diff in pull request #19873: [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

2023-03-29 Thread via GitHub
snuyanzin commented on code in PR #19873: URL: https://github.com/apache/flink/pull/19873#discussion_r1152440929 ## docs/data/sql_functions.yml: ## @@ -617,6 +617,12 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns