subject:"\[GitHub\] \[flink\] snuyanzin commented on a diff in pull request #20342\: \[FLINK\-26939\]\[Table SQL\/API\] Add TRANSLATE supported in SQL \& Table API"

[GitHub] [flink] snuyanzin commented on a diff in pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

2023-03-31 Thread via GitHub

snuyanzin commented on code in PR #20342: URL: https://github.com/apache/flink/pull/20342#discussion_r1154293981 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java: ## @@ -371,6 +371,11 @@ public static String repeat(S

[GitHub] [flink] snuyanzin commented on a diff in pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

2022-09-12 Thread GitBox

snuyanzin commented on code in PR #20342: URL: https://github.com/apache/flink/pull/20342#discussion_r968170353 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala: ## @@ -282,6 +282,13 @@ class ScalarFunctionsTe

[GitHub] [flink] snuyanzin commented on a diff in pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

2022-09-12 Thread GitBox

snuyanzin commented on code in PR #20342: URL: https://github.com/apache/flink/pull/20342#discussion_r968172962 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java: ## @@ -371,6 +371,11 @@ public static String repeat(St

[GitHub] [flink] snuyanzin commented on a diff in pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

2022-09-12 Thread GitBox

snuyanzin commented on code in PR #20342: URL: https://github.com/apache/flink/pull/20342#discussion_r968170353 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala: ## @@ -282,6 +282,13 @@ class ScalarFunctionsTe