[GitHub] [flink] snuyanzin commented on pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-02 Thread GitBox
snuyanzin commented on PR #17677: URL: https://github.com/apache/flink/pull/17677#issuecomment-1115773186 Hi @matriv thanks for your feedback, I added tests at `flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java` Also notice

[GitHub] [flink] snuyanzin commented on pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-02 Thread GitBox
snuyanzin commented on PR #17677: URL: https://github.com/apache/flink/pull/17677#issuecomment-1115274639 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [flink] snuyanzin commented on pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-02 Thread GitBox
snuyanzin commented on PR #17677: URL: https://github.com/apache/flink/pull/17677#issuecomment-1115210975 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] snuyanzin commented on pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-04-27 Thread GitBox
snuyanzin commented on PR #17677: URL: https://github.com/apache/flink/pull/17677#issuecomment-098841 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] snuyanzin commented on pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-04-25 Thread GitBox
snuyanzin commented on PR #17677: URL: https://github.com/apache/flink/pull/17677#issuecomment-1108415783 @slinkydeveloper , @matriv sorry for the poke. Since both of you are among the most active contributing to table sql could you please have a look here once you have time? -- This i