[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

2019-05-30 Thread GitBox
sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288900375 ## File path: flink-dist/pom.xml ## @@ -573,7 +573,7 @@ under the License.

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

2019-05-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288813133 ## File path: flink-dist/pom.xml ## @@ -573,7 +573,7 @@ under the License.

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

2019-05-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288812260 ## File path: flink-python/pyflink/table/types.py ## @@ -1273,6 +1318,190 @@ def _to

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

2019-05-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288812196 ## File path: flink-python/pyflink/table/types.py ## @@ -1273,6 +1318,190 @@ def _to

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

2019-05-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288812068 ## File path: flink-python/pyflink/table/types.py ## @@ -1273,6 +1318,190 @@ def _to

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

2019-05-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288808775 ## File path: flink-python/pyflink/table/table_descriptor.py ## @@ -285,6 +289,10 @@

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

2019-05-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288808037 ## File path: flink-python/pyflink/table/table_descriptor.py ## @@ -177,6 +177,10 @@

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

2019-05-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API. URL: https://github.com/apache/flink/pull/8561#discussion_r288806998 ## File path: flink-python/pyflink/table/table.py ## @@ -532,6 +533,9 @@ def insert_