[GitHub] [flink] syhily commented on a change in pull request #18816: [FLINK-26027][pulsar] add sink metrics to pulsar sink

2022-03-31 Thread GitBox
syhily commented on a change in pull request #18816: URL: https://github.com/apache/flink/pull/18816#discussion_r840254164 ## File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/UnregisteredMetricsGroup.java ## @@ -178,4 +182,35 @@ public

[GitHub] [flink] syhily commented on a change in pull request #18816: [FLINK-26027][pulsar] add sink metrics to pulsar sink

2022-03-16 Thread GitBox
syhily commented on a change in pull request #18816: URL: https://github.com/apache/flink/pull/18816#discussion_r827959064 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/writer/metrics/PulsarSinkWriterMetricUtils.java