[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-03-19 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r597682284 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepointTest.java ## @@ -0,0 +1,491 @@ +/* + *

[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-03-19 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r597674958 ## File path: flink-tests/src/test/java/org/apache/flink/test/scheduling/AdaptiveSchedulerITCase.java ## @@ -88,6 +123,189 @@ public void

[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-03-19 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r597607934 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepointTest.java ## @@ -0,0 +1,491 @@ +/* + *

[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-03-18 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r596805493 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepoint.java ## @@ -0,0 +1,328 @@ +/* + * Licensed

[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-03-12 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r593279092 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java ## @@ -143,6 +145,26 @@ public void

[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-03-12 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r593135816 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepoint.java ## @@ -0,0 +1,317 @@ +/* + * Licensed

[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-03-10 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r591539723 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepointTest.java ## @@ -0,0 +1,458 @@ +/* + *

[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-03-10 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r591459690 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java ## @@ -930,7 +952,7 @@ public void

[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-03-05 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r588461703 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointOperationManager.java ## @@ -45,18

[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-03-05 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r588365069 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java ## @@ -430,14 +430,30 @@ protected void onStart()

[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-03-05 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r587605723 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StopWithSavepointOperations.java ## @@ -18,15 +18,22 @@ package

[GitHub] [flink] tillrohrmann commented on a change in pull request #14948: [FLINK-21333][coordination] Add StopWithSavepoint state to declarative scheduler

2021-02-17 Thread GitBox
tillrohrmann commented on a change in pull request #14948: URL: https://github.com/apache/flink/pull/14948#discussion_r577607349 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/declarative/DeclarativeScheduler.java ## @@ -731,6 +731,29 @@ public