[GitHub] [flink] tisonkun commented on a diff in pull request #20584: [FLINK-26182][Connector/pulsar] Create a e2e tests for Pulsar sink.

2022-09-28 Thread GitBox
tisonkun commented on code in PR #20584: URL: https://github.com/apache/flink/pull/20584#discussion_r982665349 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/topic/range/FixedRangeGenerator.java: ## @@ -18,23 +18,40

[GitHub] [flink] tisonkun commented on a diff in pull request #20584: [FLINK-26182][Connector/pulsar] Create a e2e tests for Pulsar sink.

2022-09-27 Thread GitBox
tisonkun commented on code in PR #20584: URL: https://github.com/apache/flink/pull/20584#discussion_r981897034 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/topic/range/SplitRangeGenerator.java: ## @@ -27,27 +28,55

[GitHub] [flink] tisonkun commented on a diff in pull request #20584: [FLINK-26182][Connector/pulsar] Create a e2e tests for Pulsar sink.

2022-09-18 Thread GitBox
tisonkun commented on code in PR #20584: URL: https://github.com/apache/flink/pull/20584#discussion_r973693195 ## flink-end-to-end-tests/flink-end-to-end-tests-pulsar/src/test/java/org/apache/flink/tests/util/pulsar/PulsarSourceUnorderedE2ECase.java: ## @@ -19,21 +19,26 @@

[GitHub] [flink] tisonkun commented on a diff in pull request #20584: [FLINK-26182][Connector/pulsar] Create a e2e tests for Pulsar sink.

2022-09-16 Thread GitBox
tisonkun commented on code in PR #20584: URL: https://github.com/apache/flink/pull/20584#discussion_r973521952 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java: ## @@ -422,15 +421,12 @@ public

[GitHub] [flink] tisonkun commented on a diff in pull request #20584: [FLINK-26182][Connector/pulsar] Create a e2e tests for Pulsar sink.

2022-09-16 Thread GitBox
tisonkun commented on code in PR #20584: URL: https://github.com/apache/flink/pull/20584#discussion_r973521670 ## docs/layouts/shortcodes/generated/pulsar_consumer_configuration.html: ## @@ -58,7 +58,7 @@