[GitHub] [flink] twalthr commented on a change in pull request #18274: [FLINK-25230][table-planner] Harden type serialization for LogicalType and DataType

2022-01-08 Thread GitBox
twalthr commented on a change in pull request #18274: URL: https://github.com/apache/flink/pull/18274#discussion_r780140261 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/LogicalTypeDataTypeConverter.java ## @@ -201,9 +200,29 @@

[GitHub] [flink] twalthr commented on a change in pull request #18274: [FLINK-25230][table-planner] Harden type serialization for LogicalType and DataType

2022-01-07 Thread GitBox
twalthr commented on a change in pull request #18274: URL: https://github.com/apache/flink/pull/18274#discussion_r780327690 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/LogicalTypeJsonSerdeTest.java ## @@

[GitHub] [flink] twalthr commented on a change in pull request #18274: [FLINK-25230][table-planner] Harden type serialization for LogicalType and DataType

2022-01-07 Thread GitBox
twalthr commented on a change in pull request #18274: URL: https://github.com/apache/flink/pull/18274#discussion_r780179909 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/DataTypeJsonSerdeTest.java ## @@ -0,0

[GitHub] [flink] twalthr commented on a change in pull request #18274: [FLINK-25230][table-planner] Harden type serialization for LogicalType and DataType

2022-01-07 Thread GitBox
twalthr commented on a change in pull request #18274: URL: https://github.com/apache/flink/pull/18274#discussion_r780165059 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/LogicalTypeJsonSerializer.java ## @@

[GitHub] [flink] twalthr commented on a change in pull request #18274: [FLINK-25230][table-planner] Harden type serialization for LogicalType and DataType

2022-01-07 Thread GitBox
twalthr commented on a change in pull request #18274: URL: https://github.com/apache/flink/pull/18274#discussion_r780160827 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/LogicalTypeJsonSerializer.java ## @@

[GitHub] [flink] twalthr commented on a change in pull request #18274: [FLINK-25230][table-planner] Harden type serialization for LogicalType and DataType

2022-01-07 Thread GitBox
twalthr commented on a change in pull request #18274: URL: https://github.com/apache/flink/pull/18274#discussion_r780140261 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/LogicalTypeDataTypeConverter.java ## @@ -201,9 +200,29 @@