[GitHub] [flink] twalthr commented on a change in pull request #18283: [FLINK-25390][table] Add API to support merging options from catalog table

2022-01-07 Thread GitBox
twalthr commented on a change in pull request #18283: URL: https://github.com/apache/flink/pull/18283#discussion_r779547250 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptionsUtil.java ## @@

[GitHub] [flink] twalthr commented on a change in pull request #18283: [FLINK-25390][table] Add API to support merging options from catalog table

2022-01-07 Thread GitBox
twalthr commented on a change in pull request #18283: URL: https://github.com/apache/flink/pull/18283#discussion_r780229275 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java ## @@ -1035,8 +1124,62 @@ private String for

[GitHub] [flink] twalthr commented on a change in pull request #18283: [FLINK-25390][table] Add API to support merging options from catalog table

2022-01-07 Thread GitBox
twalthr commented on a change in pull request #18283: URL: https://github.com/apache/flink/pull/18283#discussion_r780311184 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java ## @@ -1035,8 +1124,62 @@ private String for

[GitHub] [flink] twalthr commented on a change in pull request #18283: [FLINK-25390][table] Add API to support merging options from catalog table

2022-01-07 Thread GitBox
twalthr commented on a change in pull request #18283: URL: https://github.com/apache/flink/pull/18283#discussion_r780333584 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactory.java ## @@

[GitHub] [flink] twalthr commented on a change in pull request #18283: [FLINK-25390][table] Add API to support merging options from catalog table

2022-01-08 Thread GitBox
twalthr commented on a change in pull request #18283: URL: https://github.com/apache/flink/pull/18283#discussion_r779547250 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptionsUtil.java ## @@