[GitHub] [flink] twalthr commented on a change in pull request #18980: [FLINK-26421] Use only EnvironmentSettings to configure the environment

2022-03-14 Thread GitBox
twalthr commented on a change in pull request #18980: URL: https://github.com/apache/flink/pull/18980#discussion_r825875220 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/EnvironmentSettings.java ## @@ -60,44 +57,21 @@ private stat

[GitHub] [flink] twalthr commented on a change in pull request #18980: [FLINK-26421] Use only EnvironmentSettings to configure the environment

2022-03-14 Thread GitBox
twalthr commented on a change in pull request #18980: URL: https://github.com/apache/flink/pull/18980#discussion_r825780154 ## File path: flink-python/pyflink/java_gateway.py ## @@ -132,6 +132,7 @@ def import_flink_view(gateway): """ # Import the classes used by PyFli

[GitHub] [flink] twalthr commented on a change in pull request #18980: [FLINK-26421] Use only EnvironmentSettings to configure the environment

2022-03-09 Thread GitBox
twalthr commented on a change in pull request #18980: URL: https://github.com/apache/flink/pull/18980#discussion_r822701669 ## File path: flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/internal/StreamTableEnvironmentImpl.scala #

[GitHub] [flink] twalthr commented on a change in pull request #18980: [FLINK-26421] Use only EnvironmentSettings to configure the environment

2022-03-07 Thread GitBox
twalthr commented on a change in pull request #18980: URL: https://github.com/apache/flink/pull/18980#discussion_r820476699 ## File path: flink-clients/src/main/java/org/apache/flink/client/program/StreamContextEnvironment.java ## @@ -185,6 +184,7 @@ private JobExecutionResult