[GitHub] [flink] tweise commented on pull request #20289: [FLINK-23633][FLIP-150][connector/common] HybridSource: Support dynamic stop position in FileSource

2022-07-27 Thread GitBox
tweise commented on PR #20289: URL: https://github.com/apache/flink/pull/20289#issuecomment-1196887340 @xinbinhuang thanks for describing the thought process. As you already mentioned, the goal of the JIRA was to add the passing of end position to file source and when we implemented

[GitHub] [flink] tweise commented on pull request #20289: [FLINK-23633][FLIP-150][connector/common] HybridSource: Support dynamic stop position in FileSource

2022-07-26 Thread GitBox
tweise commented on PR #20289: URL: https://github.com/apache/flink/pull/20289#issuecomment-1196163399 @xinbinhuang looking at all the modifications to HybridSource itself I think it is necessary to take a step back here and discuss the design aspects first. The underlying sources