[GitHub] [flink] tzulitai commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152666515 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] tzulitai commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152666515 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] tzulitai commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152668428 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] tzulitai commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152666515 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] tzulitai commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152597944 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void