[GitHub] [flink] wanglijie95 commented on pull request #20097: [FLINK-28284][Connectors/Jdbc] Add JdbcSink with new format

wanglijie95 commented on PR #20097: URL: https://github.com/apache/flink/pull/20097#issuecomment-1328158004 Hi @eskabetxe, thanks for your reply. 1. I think the purpose of providing three sink interfaces(Sink, StatefulSink, TwoPhaseCommittingSink) is to facilitate developers/users to inh

[GitHub] [flink] wanglijie95 commented on pull request #20097: [FLINK-28284][Connectors/Jdbc] Add JdbcSink with new format

wanglijie95 commented on PR #20097: URL: https://github.com/apache/flink/pull/20097#issuecomment-1321372510 Thanks @eskabetxe for creating this PR. I have 3 questions about the changes: 1. Do we need to introduce `JdbcProducer/NonXaJdbcProducer`? I think the existing `JdbcOutputFormat` ca

[GitHub] [flink] wanglijie95 commented on pull request #20097: [FLINK-28284][Connectors/Jdbc] Add JdbcSink with new format

wanglijie95 commented on PR #20097: URL: https://github.com/apache/flink/pull/20097#issuecomment-1318737459 @MartijnVisser I started. I may still need one more week to complete the first round review. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] wanglijie95 commented on pull request #20097: [FLINK-28284][Connectors/Jdbc] Add JdbcSink with new format

wanglijie95 commented on PR #20097: URL: https://github.com/apache/flink/pull/20097#issuecomment-1286625764 I will review this in the next few weeks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g