[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-16 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-614572139 Hi @azagrebin, both the travis and azure has passed. Could you help with merging this PR? Also for the

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-15 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-61934 @azagrebin Since a new K8s related PR has been merge, i rebase the latest master. I update the PR with

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-15 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-614371718 @flinkbot run azure This is an automa

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-15 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-613898331 @azagrebin A new follow-up tickets has been created. https://issues.apache.org/jira/browse/FLINK-171

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-15 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-613886358 @azagrebin For YARN, the `AMRMAsyncClient.unregisterApplicationMaster` is a blocking call. Currently,

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-14 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-613795334 @azagrebin Thanks for the additional comments. First, i agree with you after these changes, `FlinkKube

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-13 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-613191981 @azagrebin Thanks for the following fix. I am completely ok with the additional changes. Moreover, i a

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-13 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-613190763 @flinkbot run travis @flinkbot run azure --

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-10 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-611940486 @azagrebin I have integrated the recent comments. Please take a look at your convenience. ---

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-08 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-611331869 @flinkbot run azure This is an automa

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-08 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-611035604 @azagrebin I have integrated your improvements and rebased the new master branch. Also i add the retry

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-08 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-610800679 @flinkbot run azure This is an automa

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-07 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-610235775 @azagrebin Thanks a lot for your second round review. I have integrated the unresolved comments. Could

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-03 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-608499803 @azagrebin Thanks for your review. I have addressed most of your comments. Since some others are not a

[GitHub] [flink] wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

2020-04-03 Thread GitBox
wangyang0918 commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-608353239 @azagrebin Thanks for your review. I have addressed most of your comments. Since some others are not a