[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r414241756 ## File path: flink-core/src/main/java/org/apache/flink/types/RowKind.java ## @@ -47,10 +47,69 @@ * needs to retract the previous row first. OR

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r414237437 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala ## @@ -66,7 +66,7

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r414237437 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala ## @@ -66,7 +66,7

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r413915001 ## File path: flink-core/src/main/java/org/apache/flink/types/RowKind.java ## @@ -38,7 +38,7 @@ * to retract the previous row first. It is

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r413888446 ## File path: flink-core/src/main/java/org/apache/flink/types/RowKind.java ## @@ -47,10 +47,69 @@ * needs to retract the previous row first. OR

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r412925086 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/deduplicate/DeduplicateFunctionHelper.java ##

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r411840734 ## File path: flink-core/src/main/java/org/apache/flink/types/RowKind.java ## @@ -47,10 +47,69 @@ * needs to retract the previous row first. OR

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r411840734 ## File path: flink-core/src/main/java/org/apache/flink/types/RowKind.java ## @@ -47,10 +47,69 @@ * needs to retract the previous row first. OR

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r411487551 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowEmitStrategy.scala ## @@ -63,7 +63,7

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r411481795 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/deduplicate/DeduplicateFunctionHelper.java ##

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r411461935 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/JoinedRow.java ## @@ -17,14 +17,16 @@ package

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r411203914 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/deduplicate/DeduplicateFunctionHelper.java ##

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r411200526 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala ## @@

[GitHub] [flink] wuchong commented on a change in pull request #11797: [FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte header

wuchong commented on a change in pull request #11797: URL: https://github.com/apache/flink/pull/11797#discussion_r411198620 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowEmitStrategy.scala ## @@ -63,7 +63,7