[GitHub] [flink] wuchong commented on a change in pull request #14944: [FLINK-21297] Support 'LOAD/UNLOAD MODULE' syntax

2021-02-16 Thread GitBox
wuchong commented on a change in pull request #14944: URL: https://github.com/apache/flink/pull/14944#discussion_r576913197 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java ## @@ -864,6 +87

[GitHub] [flink] wuchong commented on a change in pull request #14944: [FLINK-21297] Support 'LOAD/UNLOAD MODULE' syntax

2021-02-17 Thread GitBox
wuchong commented on a change in pull request #14944: URL: https://github.com/apache/flink/pull/14944#discussion_r577748924 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala ## @@ -30,15 +30,15 @@ import o

[GitHub] [flink] wuchong commented on a change in pull request #14944: [FLINK-21297] Support 'LOAD/UNLOAD MODULE' syntax

2021-02-18 Thread GitBox
wuchong commented on a change in pull request #14944: URL: https://github.com/apache/flink/pull/14944#discussion_r578568850 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala ## @@ -546,13 +555,16 @@ class T