subject:"\[GitHub\] \[flink\] wuchong commented on a change in pull request #15236\: \[FLINK\-21818\]\[table\] Refactor SlicingWindowAggOperatorBuilder to accept serializer instead of LogicalType"

[GitHub] [flink] wuchong commented on a change in pull request #15236: [FLINK-21818][table] Refactor SlicingWindowAggOperatorBuilder to accept serializer instead of LogicalType

2021-03-18 Thread GitBox

wuchong commented on a change in pull request #15236: URL: https://github.com/apache/flink/pull/15236#discussion_r597401185 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/WindowKeySerializer.java ## @@ -109,10 +106,9

[GitHub] [flink] wuchong commented on a change in pull request #15236: [FLINK-21818][table] Refactor SlicingWindowAggOperatorBuilder to accept serializer instead of LogicalType

2021-03-16 Thread GitBox

wuchong commented on a change in pull request #15236: URL: https://github.com/apache/flink/pull/15236#discussion_r595262116 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/InternalTypeInfo.java ## @@ -120,6 +120,10 @@