[GitHub] [flink] wuchong commented on a diff in pull request #20211: [FLINK-28451][hive] Use UserCodeClassloader instead of the current thread's classloader to load function

2022-07-22 Thread GitBox
wuchong commented on code in PR #20211: URL: https://github.com/apache/flink/pull/20211#discussion_r927497910 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveFunctionWrapper.java: ## @@ -127,13 +125,26 @@ public Class getUDFClass(

[GitHub] [flink] wuchong commented on a diff in pull request #20211: [FLINK-28451][hive] Use UserCodeClassloader instead of the current thread's classloader to load function

2022-07-21 Thread GitBox
wuchong commented on code in PR #20211: URL: https://github.com/apache/flink/pull/20211#discussion_r926684832 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FunctionDefinitionFactory.java: ## @@ -34,4 +34,29 @@ public interface FunctionDefinitio