[GitHub] [flink] wuchong commented on a diff in pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-19 Thread via GitHub
wuchong commented on code in PR #22208: URL: https://github.com/apache/flink/pull/22208#discussion_r1141288126 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlCreateTableConverter.java: ## @@ -50,51 +49,30 @@ import java.

[GitHub] [flink] wuchong commented on a diff in pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-19 Thread via GitHub
wuchong commented on code in PR #22208: URL: https://github.com/apache/flink/pull/22208#discussion_r1141287653 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverters.java: ## @@ -37,9 +40,9 @@ public class SqlNodeC

[GitHub] [flink] wuchong commented on a diff in pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-19 Thread via GitHub
wuchong commented on code in PR #22208: URL: https://github.com/apache/flink/pull/22208#discussion_r1141276168 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverters.java: ## @@ -37,9 +40,9 @@ public class SqlNodeC

[GitHub] [flink] wuchong commented on a diff in pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-18 Thread via GitHub
wuchong commented on code in PR #22208: URL: https://github.com/apache/flink/pull/22208#discussion_r1141037935 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlCreateTableLikeConverter.java: ## @@ -0,0 +1,33 @@ +/* + * Lice