wuchong commented on issue #10316: [FLINK-14624][table-blink] Support computed
column as rowtime attribute
URL: https://github.com/apache/flink/pull/10316#issuecomment-562606314
Travis is passed: https://travis-ci.org/wuchong/flink/builds/621562944
Merging...
wuchong commented on issue #10316: [FLINK-14624][table-blink] Support computed
column as rowtime attribute
URL: https://github.com/apache/flink/pull/10316#issuecomment-562491543
rebased to resolve conficts.
This is an
wuchong commented on issue #10316: [FLINK-14624][table-blink] Support computed
column as rowtime attribute
URL: https://github.com/apache/flink/pull/10316#issuecomment-562036887
We introduced `XmlOutput` as a temporary solution to get a right plan XML.
Will be removed in FLINK-15064.
wuchong commented on issue #10316: [FLINK-14624][table-blink] Support computed
column as rowtime attribute
URL: https://github.com/apache/flink/pull/10316#issuecomment-562035759
As discussed offline, we will make `StreamExecWatermarkAssigner` and
`StreamExecMiniBatchAssigner` independent,
wuchong commented on issue #10316: [FLINK-14624][table-blink] Support computed
column as rowtime attribute
URL: https://github.com/apache/flink/pull/10316#issuecomment-561943912
Hi @godfreyhe , actually, the `StreamExecWatermarkAssigner` is responsible
for (maybe minibatch-ed) watermark
wuchong commented on issue #10316: [FLINK-14624][table-blink] Support computed
column as rowtime attribute
URL: https://github.com/apache/flink/pull/10316#issuecomment-561938757
The failed cases seem not relative to this PR.
wuchong commented on issue #10316: [FLINK-14624][table-blink] Support computed
column as rowtime attribute
URL: https://github.com/apache/flink/pull/10316#issuecomment-561457905
Hi @KurtYoung , I have rebased the pull request.