subject:"\[GitHub\] \[flink\] wuchong commented on pull request #12441\: \[FLINK\-17918\]\[table\-blink\] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState"

[GitHub] [flink] wuchong commented on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState

2020-06-04 Thread GitBox

wuchong commented on pull request #12441: URL: https://github.com/apache/flink/pull/12441#issuecomment-638761387 Thanks for the reviewing @AHeise . Will merge this. This is an automated message from the Apache Git Service. T

[GitHub] [flink] wuchong commented on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState

2020-06-03 Thread GitBox

wuchong commented on pull request #12441: URL: https://github.com/apache/flink/pull/12441#issuecomment-638146564 Wow, great thanks for the investigation. I just have time to look into this and your analysis makes sense to me. I will update the PR.