[GitHub] [flink] wuchong edited a comment on pull request #14530: [FLINK-20348][kafka] Make "schema-registry.subject" optional for Kafka sink with avro-confluent format

2020-12-30 Thread GitBox
wuchong edited a comment on pull request #14530: URL: https://github.com/apache/flink/pull/14530#issuecomment-752864472 Besides, we can remove the optional `schema-registry.subject` option for some test now, e.g. the `SQLClientSchemaRegistryITCase`. And please also update the documentation

[GitHub] [flink] wuchong edited a comment on pull request #14530: [FLINK-20348][kafka] Make "schema-registry.subject" optional for Kafka sink with avro-confluent format

2020-12-30 Thread GitBox
wuchong edited a comment on pull request #14530: URL: https://github.com/apache/flink/pull/14530#issuecomment-752863258 We should also take key format into account, and support this feature for upsert-kafka too. We may also can make `debezium-avro-confluent.schema-registry.subject` to be o