[GitHub] [flink] xuzhiwen1255 commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-04-05 Thread via GitHub
xuzhiwen1255 commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1498565719 @wuchong If you have time, please check back. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] xuzhiwen1255 commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-23 Thread via GitHub
xuzhiwen1255 commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1482107532 @wuchong Compiled through. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink] xuzhiwen1255 commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-23 Thread via GitHub
xuzhiwen1255 commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1480994794 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] xuzhiwen1255 commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-21 Thread via GitHub
xuzhiwen1255 commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1479004388 @wuchong gentle ping, please come and have a look, I've got it done, I think it should work. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] xuzhiwen1255 commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-21 Thread via GitHub
xuzhiwen1255 commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1479003248 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] xuzhiwen1255 commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-21 Thread via GitHub
xuzhiwen1255 commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1478885350 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] xuzhiwen1255 commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-21 Thread via GitHub
xuzhiwen1255 commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1478882725 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] xuzhiwen1255 commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-18 Thread via GitHub
xuzhiwen1255 commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1475073169 Thanks for @wuchong, according to the comments, I reworked the code, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [flink] xuzhiwen1255 commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-17 Thread via GitHub
xuzhiwen1255 commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1474732352 @wuchong wu @luoyuxia luo Please take a look, thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an