[GitHub] [flink] yuchuanchen commented on a diff in pull request #20616: [FLINK-29005][Connectors/Parquet] Parquet row type reader should not return null value when some child fields is null

2022-08-22 Thread GitBox
yuchuanchen commented on code in PR #20616: URL: https://github.com/apache/flink/pull/20616#discussion_r952094055 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceITCase.java: ## @@ -963,6 +971,121 @@ public void

[GitHub] [flink] yuchuanchen commented on a diff in pull request #20616: [FLINK-29005][Connectors/Parquet] Parquet row type reader should not return null value when some child fields is null

2022-08-22 Thread GitBox
yuchuanchen commented on code in PR #20616: URL: https://github.com/apache/flink/pull/20616#discussion_r952093882 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceITCase.java: ## @@ -963,6 +971,121 @@ public void

[GitHub] [flink] yuchuanchen commented on a diff in pull request #20616: [FLINK-29005][Connectors/Parquet] Parquet row type reader should not return null value when some child fields is null

2022-08-22 Thread GitBox
yuchuanchen commented on code in PR #20616: URL: https://github.com/apache/flink/pull/20616#discussion_r952093643 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceITCase.java: ## @@ -963,6 +971,121 @@ public void

[GitHub] [flink] yuchuanchen commented on a diff in pull request #20616: [FLINK-29005][Connectors/Parquet] Parquet row type reader should not return null value when some child fields is null

2022-08-22 Thread GitBox
yuchuanchen commented on code in PR #20616: URL: https://github.com/apache/flink/pull/20616#discussion_r952082659 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/columnar/vector/heap/HeapRowVector.java: ## @@ -46,4 +46,12 @@ public ColumnarRowData

[GitHub] [flink] yuchuanchen commented on a diff in pull request #20616: [FLINK-29005][Connectors/Parquet] Parquet row type reader should not return null value when some child fields is null

2022-08-22 Thread GitBox
yuchuanchen commented on code in PR #20616: URL: https://github.com/apache/flink/pull/20616#discussion_r952063956 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceITCase.java: ## @@ -963,6 +971,121 @@ public void

[GitHub] [flink] yuchuanchen commented on a diff in pull request #20616: [FLINK-29005][Connectors/Parquet] Parquet row type reader should not return null value when some child fields is null

2022-08-22 Thread GitBox
yuchuanchen commented on code in PR #20616: URL: https://github.com/apache/flink/pull/20616#discussion_r952063235 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceITCase.java: ## @@ -963,6 +971,121 @@ public void