[GitHub] [flink] zentol commented on a diff in pull request #19427: [FLINK-27140][coordination] Write job result in ioExecutor

2022-04-12 Thread GitBox
zentol commented on code in PR #19427: URL: https://github.com/apache/flink/pull/19427#discussion_r848401132 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java: ## @@ -420,7 +420,7 @@ public void testCancellationOfCanceledTerminalDoesNotThrow

[GitHub] [flink] zentol commented on a diff in pull request #19427: [FLINK-27140][coordination] Write job result in ioExecutor

2022-04-12 Thread GitBox
zentol commented on code in PR #19427: URL: https://github.com/apache/flink/pull/19427#discussion_r848401132 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java: ## @@ -420,7 +420,7 @@ public void testCancellationOfCanceledTerminalDoesNotThrow

[GitHub] [flink] zentol commented on a diff in pull request #19427: [FLINK-27140][coordination] Write job result in ioExecutor

2022-04-12 Thread GitBox
zentol commented on code in PR #19427: URL: https://github.com/apache/flink/pull/19427#discussion_r848295455 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1215,15 +1241,10 @@ private CompletableFuture waitForTerminatingJob(

[GitHub] [flink] zentol commented on a diff in pull request #19427: [FLINK-27140][coordination] Write job result in ioExecutor

2022-04-12 Thread GitBox
zentol commented on code in PR #19427: URL: https://github.com/apache/flink/pull/19427#discussion_r848287320 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java: ## @@ -420,7 +420,7 @@ public void testCancellationOfCanceledTerminalDoesNotThrow