[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1191632889 ## tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/optional/ShadeOptionalChecker.java: ## @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1191232405 ## tools/ci/flink-ci-tools/src/test/java/org/apache/flink/tools/ci/optional/ShadeOptionalCheckerTest.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software F

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1188557290 ## flink-python/pom.xml: ## Review Comment: We don't _need_ to generally speaking. IIRC the s3 filesystem is one of those hyper-problematic modules with loads of d

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1188449141 ## flink-formats/flink-sql-parquet/pom.xml: ## @@ -42,12 +42,14 @@ under the License. org.apache.flink flink-parquet

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1188442180 ## README.md: ## Review Comment: The ide setup guide says that eclipse isn't supported: `https://nightlies.apache.org/flink/flink-docs-release-1.17/docs/flinkde

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1187563240 ## tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/optional/ShadeOptionalChecker.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1187556938 ## tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/optional/ShadeOptionalChecker.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1186110665 ## tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/optional/ShadeOptionalChecker.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1186107303 ## flink-connectors/flink-sql-connector-hive-3.1.3/pom.xml: ## @@ -82,13 +84,15 @@ under the License. org.antlr antlr-run

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1186106077 ## tools/ci/verify_bundled_optional.sh: ## @@ -0,0 +1,48 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributo