[GitHub] [flink] zentol commented on a diff in pull request #22296: [FLINK-31468] Add mechanics to the Dispatcher for handling job resource requirements

2023-03-31 Thread via GitHub
zentol commented on code in PR #22296: URL: https://github.com/apache/flink/pull/22296#discussion_r1154129462 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1115,6 +1127,66 @@ private void checkJobClientAliveness() { } }

[GitHub] [flink] zentol commented on a diff in pull request #22296: [FLINK-31468] Add mechanics to the Dispatcher for handling job resource requirements

2023-03-31 Thread via GitHub
zentol commented on code in PR #22296: URL: https://github.com/apache/flink/pull/22296#discussion_r1154104747 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -944,6 +940,19 @@ public CompletableFuture notifyNewBlockedNodes(Collection> ge

[GitHub] [flink] zentol commented on a diff in pull request #22296: [FLINK-31468] Add mechanics to the Dispatcher for handling job resource requirements

2023-03-30 Thread via GitHub
zentol commented on code in PR #22296: URL: https://github.com/apache/flink/pull/22296#discussion_r1153479180 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1115,6 +1127,66 @@ private void checkJobClientAliveness() { } }

[GitHub] [flink] zentol commented on a diff in pull request #22296: [FLINK-31468] Add mechanics to the Dispatcher for handling job resource requirements

2023-03-30 Thread via GitHub
zentol commented on code in PR #22296: URL: https://github.com/apache/flink/pull/22296#discussion_r1153296770 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1115,6 +1123,45 @@ private void checkJobClientAliveness() { } }

[GitHub] [flink] zentol commented on a diff in pull request #22296: [FLINK-31468] Add mechanics to the Dispatcher for handling job resource requirements

2023-03-30 Thread via GitHub
zentol commented on code in PR #22296: URL: https://github.com/apache/flink/pull/22296#discussion_r1153130025 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1115,6 +1123,45 @@ private void checkJobClientAliveness() { } }

[GitHub] [flink] zentol commented on a diff in pull request #22296: [FLINK-31468] Add mechanics to the Dispatcher for handling job resource requirements

2023-03-30 Thread via GitHub
zentol commented on code in PR #22296: URL: https://github.com/apache/flink/pull/22296#discussion_r1153107044 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1115,6 +1123,45 @@ private void checkJobClientAliveness() { } }

[GitHub] [flink] zentol commented on a diff in pull request #22296: [FLINK-31468] Add mechanics to the Dispatcher for handling job resource requirements

2023-03-30 Thread via GitHub
zentol commented on code in PR #22296: URL: https://github.com/apache/flink/pull/22296#discussion_r1153067234 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1115,6 +1123,45 @@ private void checkJobClientAliveness() { } }

[GitHub] [flink] zentol commented on a diff in pull request #22296: [FLINK-31468] Add mechanics to the Dispatcher for handling job resource requirements

2023-03-30 Thread via GitHub
zentol commented on code in PR #22296: URL: https://github.com/apache/flink/pull/22296#discussion_r1153058503 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1115,6 +1123,45 @@ private void checkJobClientAliveness() { } }