[GitHub] [flink] zentol commented on issue #9870: [FLINK-14350][metrics] Introduce dedicated MetricScope

2019-10-17 Thread GitBox
zentol commented on issue #9870: [FLINK-14350][metrics] Introduce dedicated MetricScope URL: https://github.com/apache/flink/pull/9870#issuecomment-543077224 Having a default implementation makes sense, will add it. This is a

[GitHub] [flink] zentol commented on issue #9870: [FLINK-14350][metrics] Introduce dedicated MetricScope

2019-10-16 Thread GitBox
zentol commented on issue #9870: [FLINK-14350][metrics] Introduce dedicated MetricScope URL: https://github.com/apache/flink/pull/9870#issuecomment-542603076 Retrieving the filter once after the initialization is a good idea.

[GitHub] [flink] zentol commented on issue #9870: [FLINK-14350][metrics] Introduce dedicated MetricScope

2019-10-16 Thread GitBox
zentol commented on issue #9870: [FLINK-14350][metrics] Introduce dedicated MetricScope URL: https://github.com/apache/flink/pull/9870#issuecomment-542596647 Logical scopes will be properly exposed in a follow-up. This is an

[GitHub] [flink] zentol commented on issue #9870: [FLINK-14350][metrics] Introduce dedicated MetricScope

2019-10-10 Thread GitBox
zentol commented on issue #9870: [FLINK-14350][metrics] Introduce dedicated MetricScope URL: https://github.com/apache/flink/pull/9870#issuecomment-540595411 > Reporters relying on now deprecated methods have been updated, **except for the JMX, Prometheus and InfluxDB reporters as they s