[GitHub] [flink] zentol commented on pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

2023-04-04 Thread via GitHub
zentol commented on PR #22313: URL: https://github.com/apache/flink/pull/22313#issuecomment-1495514815 You need to do it on the command-line so that the loader jar (that is actually used) is built properly. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [flink] zentol commented on pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

2023-04-03 Thread via GitHub
zentol commented on PR #22313: URL: https://github.com/apache/flink/pull/22313#issuecomment-1493873775 > flink-table-planner-loader-bundle, flink-table-planner-loader, flink-table-planner_${scala.binary.version} Did you rebuild these modules after the change on the command-line? --

[GitHub] [flink] zentol commented on pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

2023-03-31 Thread via GitHub
zentol commented on PR #22313: URL: https://github.com/apache/flink/pull/22313#issuecomment-1491780342 You may also be able to work around this issue by working against https://github.com/apache/flink-connector-kafka instead. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] zentol commented on pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

2023-03-31 Thread via GitHub
zentol commented on PR #22313: URL: https://github.com/apache/flink/pull/22313#issuecomment-1491680270 I'd also suggest to look into https://issues.apache.org/jira/browse/FLINK-31660?focusedCommentId=17707214&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17707

[GitHub] [flink] zentol commented on pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

2023-03-31 Thread via GitHub
zentol commented on PR #22313: URL: https://github.com/apache/flink/pull/22313#issuecomment-1491678202 Mind you, that merging this to release-1.17 is a completely different story. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [flink] zentol commented on pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

2023-03-31 Thread via GitHub
zentol commented on PR #22313: URL: https://github.com/apache/flink/pull/22313#issuecomment-1491677580 > But is there something wrong with fixing this issue for the time being here? It breaks the code freeze that we decided on the ML. If you want to merge it regardless, then please b

[GitHub] [flink] zentol commented on pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

2023-03-31 Thread via GitHub
zentol commented on PR #22313: URL: https://github.com/apache/flink/pull/22313#issuecomment-1491601098 This also is arguably not really an IntelliJ issue, but more of how the planner dependencies are organized. The planner modules apply several relocations (to, for example, jayway) bu