zentol opened a new pull request #19019:
URL: https://github.com/apache/flink/pull/19019


   To allow recovered TMs to eagerly re-offer their slots we allowed the 
registration of slots without a matching requirement if the job is currently 
restarting.
   
   All slots that the pool accepts are mapped to a certain requirement, in 
order to determine whether sufficient slots were received yet. If a slot is 
reserved for a requirement that does not coincide with the mapping the pool 
come up with, then the mapping and requirements are changed accordingly to 
ensure we still request sufficient slots.
   
   This leads to issues with slots that were accepted without a matching 
requirement. Those were mapped to the actual resource profile of the slot (to 
fit into the book-keeping). With the above logic in place this could lead to a 
specific resource requirement being added, which the remaining JM components 
are not aware of (and thus will never get rid of).
   
   
   This PR fixes the issue by mapping such slots to `ResourceProfile.ANY` as a 
sort of sentinel value, and skipping the requirement adjustment if such a slot 
is reserved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to