zhijiangW commented on issue #11441: [FLINK-16653][network][tests] Introduce ResultPartitionWriterTestBase for simplifying tests URL: https://github.com/apache/flink/pull/11441#issuecomment-600965182 Thanks for the review @zentol and @AHeise ! I addressed the above comments. Regarding the builder way for `ResultPartitionWriter`, we almost have the builder for specific instance class, like `ResultPartitionBuilder` for constructing `ResultPartition` instance, seldom for interface builder I guess. So I prefer the current way if no strongly advice. :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
