zhijiangW commented on issue #8090: [FLINK-12067][network] Refactor the
constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8090#issuecomment-482500738
Thanks for merging and the kindly reminder. I would copy it to the commit
next time. :)
zhijiangW commented on issue #8090: [FLINK-12067][network] Refactor the
constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8090#issuecomment-481971372
@pnowojski , thanks for your review! I have rebased the master to solve the
conflicts.
zhijiangW commented on issue #8090: [FLINK-12067][network] Refactor the
constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8090#issuecomment-480923758
@azagrebin thanks for review again. I submitted the commit for addressing
left comments.
zhijiangW commented on issue #8090: [FLINK-12067][network] Refactor the
constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8090#issuecomment-479745830
@azagrebin , thanks for review again. :)
I submitted the commit for rebasing master and addressing the above
zhijiangW commented on issue #8090: [FLINK-12067][network] Refactor the
constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8090#issuecomment-478948597
@azagrebin I submitted two separate fixup commits for addressing above
comments.
zhijiangW commented on issue #8090: [FLINK-12067][network] Refactor the
constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8090#issuecomment-478910261
Thanks for reviews and suggestions @azagrebin .
I agree to further move `parseNetworkEnvironmentConfiguration`
