zhijiangW commented on pull request #13523:
URL: https://github.com/apache/flink/pull/13523#issuecomment-719465267
@StephanEwen, I have updated the codes for addressing above comments.
Regards the tests, I think the existing `BoundedBlockingSubpartitionTest`
and `BoundedBlockingSubp
zhijiangW commented on pull request #13523:
URL: https://github.com/apache/flink/pull/13523#issuecomment-718688119
Thanks for the further confirmation @StephanEwen !
> Do we need to FileRegionResponse to extend DefaultFileRegion, or can the
FileRegionResponse contain a DefaultFileReg
zhijiangW commented on pull request #13523:
URL: https://github.com/apache/flink/pull/13523#issuecomment-717095708
Thanks for your pretty suggestive reviews @StephanEwen and I really get some
profound, original insights from you!
> Compatibility with SSL
I really overlooked t
zhijiangW commented on pull request #13523:
URL: https://github.com/apache/flink/pull/13523#issuecomment-713465353
I supplemented a new micro-benchmark case for verifying the change via
[PR](https://github.com/apache/flink-benchmarks/pull/4), and the results as
below seem no obvious change
zhijiangW commented on pull request #13523:
URL: https://github.com/apache/flink/pull/13523#issuecomment-711483920
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message, pleas
zhijiangW commented on pull request #13523:
URL: https://github.com/apache/flink/pull/13523#issuecomment-708994253
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message, pleas
zhijiangW commented on pull request #13523:
URL: https://github.com/apache/flink/pull/13523#issuecomment-707562596
FYI, the last four commits separation is only for easy review, will be
squashed finally before merging.
This
